Temporary fix for keytar on Apple Silicon #11969
Conversation
|
I downloaded it from releases |
|
Following steps here, I ran
|
|
@trulyronak Thanks! Based on @dennisameling's response here (#9691 (comment)), I think the fs admin error is expected. |
|
For those interested, I uploaded a test build that fixes both keytar (with the changes from this PR) and fs-admin issues (by including my changes in atom/fs-admin#105 and atom/fs-admin#106)! Please, give it a try and let me know if it works for you. It definitely does for me! Download: https://s3.amazonaws.com/github-desktop/releases/2.7.3-test4-0e14ef24/GitHubDesktop-arm64.zip |
Thanks for creating this release! It almost works on macOS 11.3 for me, in that it launches but there's an immediate error:
From this point, the app is nonfunctional. The UI shows up, but when I try to add a repo, for instance, the Add Repo button never gets activated so I cannot continue. |
|
It looks like The Apple Silicon machine I'm testing this on does not have Rosetta 2 installed. @sergiou87 is it possible that there's still some singular Intel dependency in your package and Desktop is trying to run something in the background that requires Intel emulation (and which fails without Rosetta 2 installed?) |
|
@jensenharris @sergiou87 it seems that the git bundled with Github Desktop in the provided build is x86_64. |
|
Ouch, great catch! I'll look into that, thank you!! ❤️ |
Thank you! I'm looking forward to the updated Apple Silicon build! |
|
Thankfully this PR is not needed anymore (thank you for all your work @dennisameling!! ❤️ ), and the last beta is already working on Apple Silicon devices 😄 It still has git binaries for x86_64, but I almost have sorted that out, stay tuned… 😄 |
|
@jensenharris @spacentropy could you try this build out? [Link removed because it wasn't 100% arm64 yet, sorry!] Specially if you don't have Rosetta… git and git-lfs are built for arm64 in that release, so hopefully there is nothing else missing!! 🤞 |
|
I noticed two binaries escaped the upgrade to arm64. I took care of them here: #12091 and will upload a new test build soon. Sorry about that! |
|
Here we go, new arm64 build that should be 100% arm64: [Link removed because now it's in beta!] 🤞 EDIT: You can now download the arm64 beta from https://central.github.com/deployments/desktop/desktop/latest/darwin-arm64?env=beta |
This is sooo awesome!! It works!! M1 baby! Thank you! |
Related to #9691 (comment)
There are issues with Electron arm64 builds on Apple Silicon when using keytar. Related issue: atom/node-keytar#346.
Keytar will (likely quite soon) switch to N-API prebuilds which eliminates the needs for them to publish prebuilds for every Node + Electron version (currently at 92 (!) prebuilds https://github.com/atom/node-keytar/releases/tag/v7.6.0), see atom/node-keytar#331. I've created a temporary Keytar release based on that PR: https://www.npmjs.com/package/@dennisameling/keytar-temp
The alternatives to merging this PR are:
A release for testing on Apple Silicon can be found here: https://github.com/dennisameling/desktop/releases/tag/2.7.3-test