Workaround for Electron issue with setImmediate #12765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
requested changes
Aug 12, 2021
eslint-rules/set-almost-immediate.js
Outdated
| const sourceCode = context.getSourceCode() | ||
|
|
||
| /** | ||
| * Check each member of the interface body and ensure it is marked `readonly`. |
There was a problem hiding this comment.
Ouch! Fixed now, thanks 😄
| // @ts-check | ||
|
|
||
| /** | ||
| * set-almost-immediate |
There was a problem hiding this comment.
These custom rules are neat!
|
@sergiou87 ESLint rules look fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a workaround for electron/electron#29261 that basically replaces calls to
setImmediatewithsetTimeout(…, 0).Given it will need some time in testing, I created a very original abstraction with
setAlmostImmediateand wrote an eslint rule to make sure we don't usesetImmediate(@shiftkey I'd love if you could take a look at it and share any feedback… but only if you have time!!!)After testing it, I haven't noticed any issues, and of course I wasn't able to repro the aforementioned issue after bumping Electron to one of the affected versions, so we could say this temporary workaround is actually useful 😌
Release notes
Notes: no-notes