Use macos-13-xl-arm64 M1 runner #17110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2023
Closed
|
So previously we had it set such that we would only run tests when the actual architecture matched the target arch. Now we are running on native arm (on macOS) but we still only run tests in x64. Should we change it so that we only run tests on macOS/arm and Windows/x64? |
|
Ah. I wondered why we only did it on the x64 builds. It seems that in the reference issue indicates the tests failed for arm64 when not running on an arm64 windows machine. This does not seem to be the case for macOS. What is the benefit of switching? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known constraint -> Uses Node 16 which we already do.