Log shell.openExternal errors
#8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electron's shell.openExternal changed to become async so in order to ensure that errors don't get lost in the async void we need to explicitly catch them. I'm choosing to log them rather than throw because surfacing the error to the user doesn't add any value. They'll notice that something is wrong by virtue of the fact that their browser didn't open correctly. The logging will be helpful for us developers when we're trying to debug what went wrong.
kuychaco
added
the
ready-for-review
kuychaco
moved this from Needs to be Prioritized
to ⭐️ PR Reviewable Priority ⭐️
in PR Priority
PR Priority
automation
moved this from ⭐️ PR Reviewable Priority ⭐️
to Review in progress
Sep 11, 2019
niik
requested changes
Sep 11, 2019
mislav
reviewed
Sep 11, 2019
|
took a quick pass at this to get it across the line after discussing briefly with @kuychaco on friday. i had misunderstood
|
niik
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a follow-on PR to #8220, which had closed #8156
Description
Electron's
shell.openExternalchanged to become async so in order to ensure that errors don't get lost in the async void we need to explicitly catch them.I'm choosing to log them rather than throw because surfacing the error to the user doesn't add any value. They'll notice that something is wrong by virtue of the fact that their browser didn't open correctly.
The logging will be helpful for us developers when we're debugging what went wrong and save us time identifying the root cause.
Release notes
Notes: no-notes