Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log shell.openExternal errors #8246

Merged
merged 7 commits into from Oct 1, 2019
Merged

Log shell.openExternal errors #8246

merged 7 commits into from Oct 1, 2019

Commits on Sep 11, 2019

  1. Log shell.openExternal errors

    Electron's shell.openExternal changed to become async so in order to ensure that errors don't get lost in the async void we need to explicitly catch them.
    
    I'm choosing to log them rather than throw because surfacing the error to the user doesn't add any value. They'll notice that something is wrong by virtue of the fact that their browser didn't open correctly.
    
    The logging will be helpful for us developers when we're trying to debug what went wrong.
    kuychaco committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    f192bfe View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. remove bad import

    outofambit committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    559a539 View commit details
    Browse the repository at this point in the history
  2. reformat errors

    outofambit committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    ac3e618 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5169d61 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e5b0a69 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Configuration menu
    Copy the full SHA
    f4e4478 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06ca5db View commit details
    Browse the repository at this point in the history