Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Electron 6 #8791

Closed
wants to merge 20 commits into from
Closed

Upgrade to Electron 6 #8791

wants to merge 20 commits into from

Commits on Dec 12, 2019

  1. Upgrade Electron to 6.1.6

    @kuychaco
    kuychaco committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    a80b050 View commit details
    Browse the repository at this point in the history

  2. Fix ipc event types 

    Co-Authored-By: Josh Abernathy <joshaber@gmail.com>
    @kuychaco @joshaber
    kuychaco and joshaber committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    1cbb5be View commit details
    Browse the repository at this point in the history

  3. Fix role type 

    Co-Authored-By: Josh Abernathy <joshaber@gmail.com>
    @kuychaco @joshaber
    kuychaco and joshaber committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    b19f4f8 View commit details
    Browse the repository at this point in the history

  4. Fix dialog.showOpenDialog API 

    Co-Authored-By: Josh Abernathy <joshaber@gmail.com>
    @kuychaco @joshaber
    kuychaco and joshaber committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    1cf8820 View commit details
    Browse the repository at this point in the history

  5. dialog.showMessageBox is now promisified

    @kuychaco
    kuychaco committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    3a62011 View commit details
    Browse the repository at this point in the history

  6. Explicitly opt in to app log directory creation

    @kuychaco
    kuychaco committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    5b8ed26 View commit details
    Browse the repository at this point in the history

  7. Update npmrc build target

    @kuychaco
    kuychaco committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    63ba09e View commit details
    Browse the repository at this point in the history

  8. WIP fix things

    @kuychaco
    kuychaco committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    8e1ec73 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Drop the no-sandbox chromium flag, as it doesn't seem to be necessary 

    Co-Authored-By: evelyn masso <outofambit@github.com>
    @kuychaco @outofambit
    kuychaco and outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    c2bbc2e View commit details
    Browse the repository at this point in the history

  2. Bump keytar to 4.13.0, which is required for Electron 6 

    Co-Authored-By: evelyn masso <outofambit@github.com>
    @kuychaco @outofambit
    kuychaco and outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    e929cf9 View commit details
    Browse the repository at this point in the history

  3. Keep tabs from shrinking 

    Co-Authored-By: evelyn masso <outofambit@github.com>
    @kuychaco @outofambit
    kuychaco and outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    fe8df83 View commit details
    Browse the repository at this point in the history

  4. Add max heights to keep things from dripping 

    Commit box melts down off the screen

Co-Authored-By: evelyn masso <outofambit@github.com>
    @kuychaco @outofambit
    kuychaco and outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    41952aa View commit details
    Browse the repository at this point in the history

  5. Delete electron-notarize+0.0.5.patch 

    doesn't jive with our new deps
    @outofambit
    outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    4898ffb View commit details
    Browse the repository at this point in the history

  6. fix heights css 

    i think i fixed this incorrectly for the electron 5 upgrade. hopefully this is more correct.
    @outofambit
    outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    a371ed3 View commit details
    Browse the repository at this point in the history

  7. Bump electron-packager to 14.1.1 (to get electron-notarize 0.2.0) 

    This replaces the patch for osx-notarize removed in 4898ffb, which was causing the build to fail

See electron/packager#1069

Co-Authored-By: evelyn masso <outofambit@github.com>
    @kuychaco @outofambit
    kuychaco and outofambit committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    929fc4f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Add script/coverage to .prettierignore

    @kuychaco
    kuychaco committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    cb52d80 View commit details
    Browse the repository at this point in the history

  2. Prettier 💅 

    node_modules/.bin/prettier --write app/src/ui/app.tsx
    @mislav
    mislav committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    aed68ff View commit details
    Browse the repository at this point in the history

  3. disable no-sync eslint rule for dialog.showOpenDialogSync

    @kuychaco
    kuychaco committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    495c9d2 View commit details
    Browse the repository at this point in the history

  4. 2.4.0-test1 for Electron Upgrade testing

    @kuychaco
    kuychaco committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    ed9dd1a View commit details
    Browse the repository at this point in the history

  5. Actually, do 2.3.0-test1 

    Co-Authored-By: evelyn masso <outofambit@github.com>
    @kuychaco @outofambit
    kuychaco and outofambit committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    d81db7c View commit details
    Browse the repository at this point in the history