Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Electron 6 #8791

Closed
wants to merge 20 commits into from
Closed

Upgrade to Electron 6 #8791

wants to merge 20 commits into from

Conversation

kuychaco
Copy link
Contributor

@kuychaco kuychaco commented Dec 12, 2019 •
edited

⚠️Superseded by #8967 ⚠️

Kicking off the work to move us to Electron 6, as Electron 5 will be unsupported in the coming months (once Electron 8 is released)

Release notes

Notes:

@tierninho
Copy link
Contributor

I combed through the 230+ known issues with Electron 6 (at least the labeled ones) to try an uncover any potential bugs that we may face. Most were one-offs will little to go, as anything major was already squashed.

Some trends I spotted are below, which I will keep my eye on when testing commences in a few days.

6.1.x known issues with:

  • iframe/ webFrame
  • Zooming, Full screen mode, resizing windows
  • Native tabs

6.0.x known issues with:

@nerdneha nerdneha added this to In Progress PRs in Desktop 2.3 release via automation Dec 13, 2019
kuychaco and others added 12 commits December 19, 2019 11:07
@kuychaco @outofambit
Drop the no-sandbox chromium flag, as it doesn't seem to be necessary
c2bbc2e 
Co-Authored-By: evelyn masso <outofambit@github.com>
@kuychaco @outofambit
Bump keytar to 4.13.0, which is required for Electron 6
e929cf9 
Co-Authored-By: evelyn masso <outofambit@github.com>
@kuychaco @outofambit
Keep tabs from shrinking
fe8df83 
Co-Authored-By: evelyn masso <outofambit@github.com>
@kuychaco @outofambit
Add max heights to keep things from dripping
41952aa 
Commit box melts down off the screen

Co-Authored-By: evelyn masso <outofambit@github.com>
@outofambit
Delete electron-notarize+0.0.5.patch
4898ffb 
doesn't jive with our new deps
@outofambit
fix heights css
a371ed3 
i think i fixed this incorrectly for the electron 5 upgrade. hopefully this is more correct.
@kuychaco @outofambit
Bump electron-packager to 14.1.1 (to get electron-notarize 0.2.0)
929fc4f 
This replaces the patch for osx-notarize removed in 4898ffb, which was causing the build to fail

See electron/packager#1069

Co-Authored-By: evelyn masso <outofambit@github.com>
@kuychaco
Add script/coverage to .prettierignore
cb52d80
@mislav
Prettier 💅
aed68ff 
node_modules/.bin/prettier --write app/src/ui/app.tsx
@kuychaco
disable no-sync eslint rule for dialog.showOpenDialogSync
495c9d2
@kuychaco
2.4.0-test1 for Electron Upgrade testing
ed9dd1a
@kuychaco @outofambit
Actually, do 2.3.0-test1
d81db7c 
Co-Authored-By: evelyn masso <outofambit@github.com>
@kuychaco
Copy link
Contributor Author

@tierninho reports after smoke testing:

All is checking out thus far in Mac and Windows ✅ Will do a more thorough round after the holidays

@niik niik mentioned this pull request Jan 7, 2020
Closed
@kuychaco
Copy link
Contributor Author

kuychaco commented Jan 8, 2020

@tierninho further reports:

no issues have been found upon further testing in Mac/Windows.

🎉

@tierninho
Copy link
Contributor

As we do not have an Electron 7 issue/PR yet, I am posting some observations here in regards to known issues with v7:

Window resizing

Loading:

Keyboard:

This was referenced Jan 22, 2020
Closed
Merged
@kuychaco
Copy link
Contributor Author

kuychaco commented Feb 3, 2020

Closing this as it has been superseded by #8967

@kuychaco kuychaco closed this Feb 3, 2020
@kuychaco kuychaco removed this from In Progress PRs in Desktop 2.3 release Feb 5, 2020
@niik niik mentioned this pull request Feb 25, 2020
Closed
@Adamsmith66

This comment has been minimized.

Sign in to view
@outofambit outofambit deleted the ku-electron-6-upgrade branch April 27, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kuychaco @tierninho @Adamsmith66 @outofambit @mislav