Upgrade to Electron 7 #8959
Closed
Upgrade to Electron 7 #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Josh Abernathy <joshaber@gmail.com>
Co-Authored-By: Josh Abernathy <joshaber@gmail.com>
Co-Authored-By: Josh Abernathy <joshaber@gmail.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
Commit box melts down off the screen Co-Authored-By: evelyn masso <outofambit@github.com>
doesn't jive with our new deps
i think i fixed this incorrectly for the electron 5 upgrade. hopefully this is more correct.
This replaces the patch for osx-notarize removed in 4898ffb, which was causing the build to fail See electron/packager#1069 Co-Authored-By: evelyn masso <outofambit@github.com>
node_modules/.bin/prettier --write app/src/ui/app.tsx
Co-Authored-By: evelyn masso <outofambit@github.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
This reverts commit 535149e.
This reverts commit 05e9a3c.
|
Closing this as it's been superseded by #8967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes us from Electron v6 to v7. Note that #8791 contains the work that takes us from Electron v5 (currently on stable) to v6. I'm keeping these PRs separate to make it easier to review the change-set associated with each version bump.
If all looks good with Electron v7 we'll ship it. If not, we'll fall back to shipping with Electron v6.
Bugs to test / keep in mind
bluron certain types of items · Issue #20608<select>Boxes like [stashing] Double clicks of buttons throws error and double log entries #7289 with 7.1.1 and WINDOWS · Issue #21152Release notes
Notes: