Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usages of MutliRule in detekt code base #5192

Closed
7 tasks done
marschwar opened this issue Aug 6, 2022 · 5 comments · Fixed by #6288
Closed
7 tasks done

Remove all usages of MutliRule in detekt code base #5192

marschwar opened this issue Aug 6, 2022 · 5 comments · Fixed by #6288
Assignees
Labels
never gets stale Mark Issues/PRs that should not be closed as they won't get stale rules

Comments

@marschwar
Copy link
Contributor

marschwar commented Aug 6, 2022

We decided to remove the MultiRule construct for all the reasons mentioned in #4240. As it is part of the API we cannot remove support for it just yet but we can change all those places where we use it for first party rules.

This issue keeps track of all the tasks necessary.

@chao2zhang
Copy link
Member

chao2zhang commented Sep 18, 2022

KtLintMultiRule seems to be the last multi rule in source set. I will take a stab at it in #5312

Update:
I will probably still perform the ktlint upgrades first, then refactor off MultiRule.
The reason behind this is because there are internal orders to execute ktlint rules, hence we need to extract the ordering logic into Detekt's Analyzer.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Dec 18, 2022
@cortinico
Copy link
Member

I will probably still perform the ktlint upgrades first, then refactor off MultiRule.

This is still a think, as suggested by @chao2zhang.
The last multirule is the KtLint one

@cortinico cortinico added never gets stale Mark Issues/PRs that should not be closed as they won't get stale and removed stale labels Dec 19, 2022
@marschwar
Copy link
Contributor Author

Have you started to work on it @chao2zhang? I could pick it up If you like.

@chao2zhang
Copy link
Member

I have not. Please feel free to explore, although I think updating to ktlint 0.49 would be a prerequisite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never gets stale Mark Issues/PRs that should not be closed as they won't get stale rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants