Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete MultiRule #6288

Merged
merged 1 commit into from Jul 16, 2023
Merged

Delete MultiRule #6288

merged 1 commit into from Jul 16, 2023

Conversation

cortinico
Copy link
Member

@cortinico cortinico commented Jul 15, 2023

We can finally remove MultiRule as we're not using it anymore.
This is also a breaking change that will be shipped with 2.0.0

Fixes #5192

@cortinico cortinico added this to the 2.0.0 milestone Jul 15, 2023
@cortinico cortinico added the breaking change Marker for breaking changes which should be highlighted in the changelog label Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #6288 (f04840c) into main (e7d2276) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main    #6288      +/-   ##
============================================
+ Coverage     85.19%   85.20%   +0.01%     
+ Complexity     4029     4017      -12     
============================================
  Files           568      567       -1     
  Lines         13421    13390      -31     
  Branches       2376     2371       -5     
============================================
- Hits          11434    11409      -25     
+ Misses          829      825       -4     
+ Partials       1158     1156       -2     
Impacted Files Coverage Δ
...kotlin/io/gitlab/arturbosch/detekt/api/BaseRule.kt 95.45% <ø> (-4.55%) ⬇️
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 86.27% <ø> (+0.83%) ⬆️
...b/arturbosch/detekt/core/suppressors/Suppressor.kt 66.66% <ø> (-4.77%) ⬇️
...n/io/github/detekt/report/sarif/RuleDescriptors.kt 36.84% <0.00%> (+6.40%) ⬆️
...io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt 96.15% <100.00%> (+6.49%) ⬆️

... and 1 file with indirect coverage changes

@3flex
Copy link
Member

3flex commented Jul 15, 2023

Closes #5192 I assume?

@cortinico
Copy link
Member Author

Closes #5192 I assume?

Yup added 👍

@cortinico cortinico merged commit 0aa6402 into main Jul 16, 2023
22 of 23 checks passed
@cortinico cortinico deleted the nc/delete-multirule branch July 16, 2023 17:12
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking change Marker for breaking changes which should be highlighted in the changelog core rules suppressors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all usages of MutliRule in detekt code base
4 participants