Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi rule FileParsingRule #5193

Merged
merged 1 commit into from Aug 7, 2022

Conversation

marschwar
Copy link
Contributor

This is part of #5192.

All rules from the FileParsingRule multi rule are now run individually.

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #5193 (370e440) into main (6061f29) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5193   +/-   ##
=========================================
  Coverage     84.96%   84.96%           
- Complexity     3638     3640    +2     
=========================================
  Files           502      502           
  Lines         11985    11982    -3     
  Branches       2260     2260           
=========================================
- Hits          10183    10181    -2     
+ Misses          689      688    -1     
  Partials       1113     1113           
Impacted Files Coverage Δ
...lab/arturbosch/detekt/rules/style/KtFileContent.kt 100.00% <100.00%> (ø)
...lab/arturbosch/detekt/rules/style/MaxLineLength.kt 93.75% <100.00%> (+0.41%) ⬆️
.../io/gitlab/arturbosch/detekt/rules/style/NoTabs.kt 92.30% <100.00%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <100.00%> (ø)
...rturbosch/detekt/rules/style/TrailingWhitespace.kt 96.66% <100.00%> (+0.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 6, 2022

Messages
📖 Thanks for adding a new rule to Detekt ❤️

Generated by 🚫 dangerJS against 370e440

@marschwar marschwar added the housekeeping Marker for housekeeping tasks and refactorings label Aug 6, 2022
@schalkms schalkms added this to the 1.22.0 milestone Aug 6, 2022
@schalkms
Copy link
Member

schalkms commented Aug 6, 2022

@cortinico seems to be an issue with danger and the GitHub rate limit. Is there something to adapt in the setup?

Request failed [403]: https://api.github.com/repos/detekt/detekt/pulls/5193
[19](https://github.com/detekt/detekt/runs/7707582017?check_suite_focus=true#step:5:20)
Response: {
[20](https://github.com/detekt/detekt/runs/7707582017?check_suite_focus=true#step:5:21)
  "message": "API rate limit exceeded for installation ID 7815900.",
[21](https://github.com/detekt/detekt/runs/7707582017?check_suite_focus=true#step:5:22)
  "documentation_url": "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"
[22](https://github.com/detekt/detekt/runs/7707582017?check_suite_focus=true#step:5:23)
}

@cortinico
Copy link
Member

Is there something to adapt in the setup?

Not really. The problem is with codecov though. For some reason it seems like they post a comment that they edit over and over:

Screenshot 2022-08-06 at 23 43 29

This is generating 200+ invocations of the Danger workflow causing the own Github token to go out of quota. The labeller also failed.
This should be reported to the Codecov App I believe.

I'm looking into potentially skipping the workflow if the event trigger was coming from Codecov

@schalkms
Copy link
Member

schalkms commented Aug 6, 2022

Ouch. 🙈

This is generating 200+ invocations of the Danger workflow causing the own Github token to go out of quota.


internal data class KtFileContent(val file: KtFile, val content: Sequence<String>)

internal fun KtFile.toFileContent() = KtFileContent(this, text.splitToSequence("\n"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ for internal

@github-actions github-actions bot added the rules label Aug 7, 2022
@marschwar marschwar merged commit cdd2d71 into detekt:main Aug 7, 2022
@marschwar marschwar deleted the remove-file-parsing-rule branch August 7, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants