Detekt 1.22.0 is getting noisier and noisier #5436
Labels
Milestone
Comments
|
Note: I would consider this a regression in this version. And a potential solution might be introducing a new log level similar to There's nothing I can do about any of these warnings (this is why I called them "noise"):
There's nothing to do, I cannot remove java / kapt plugins from those modules, and git cannot version empty folders, especially ones that are not necessary.
This is because test/testFixtures friends are missing, so again, we cannot solve it in our projects. |
|
Same thing on Detekt itself: gradlew detektMain detektTestGood luck quickly reading the findings... Expected: Note that Detekt is a small project, at work we have ~250 modules, and I think even that is a medium project only. |
|
I see diferent issues listed here. But I agree, the About the message "The BindingContext was created with 242 issues. [...]": I think it is good to keep it there there. It ensure the idea that type solving is still not solving everything at the moment so detekt could have some false negatives. |
|
I think the key here is that these warnings are unfixable (in both cases) by end users of Detekt, but they get bugged about it every single execution. Average Joe developer at Big Company doesn't care or know about this, even me as a contributor still raise my eyebrow at |
|
I would like to know what other people think about this. For sure we can completely remove the "The BindingContext was created with 242 issues. [...]" message. For me this situation is odd because in one hand type resolution is still experimental and have some rought edges. On the other hand half of the rules of detekt use type resolution and I think that all the maintainer doesn't think too much about detekt without type solving. It would be great to make the our compiler plugin production ready to fix all these issues but we need hands for doing that.
☝️ To me this is a really good reason to remove that message. |
|
I think those messages are inactionable and will condition users to tune out detekt logs by default |
+1 on suppressing this. End users don't need to know what a |
This was referenced Oct 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
No output in Gradle console log unless there's an actual problem.
1.21.0:
Current Behavior
1.22.0-RC1:
1.22.0-RC2:
Notice that even the number of
BindingContextissues are getting higher.Context
gradlew ...is usually empty, and that's a good thing. The more warnings show up the less likely is that we see new warnings pop up, and long term projects end up with just megabytes of logs which no-one cares about.The project I was executing on is exactly the same code for each version. The task I was running was also exactly the same for each version:
gradlew :plugins:detektEach detektMain detektTest detektTestFixtures --rerun-tasks(detektEachdepends on detekt, detektMain and detektTest in that module).The text was updated successfully, but these errors were encountered: