Don't show the number of issues generating the BindingContext #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
Oct 19, 2022
|
|
||
| fun printIssuesCountIfAny() { | ||
| if (messages > 0) { | ||
| warningPrinter( |
There was a problem hiding this comment.
rather than fully killing put it behind the debug? or does that already print the number of problems? I should probably check 😂
There was a problem hiding this comment.
I double-checked, when running with debug mode, it doesn't print the number of compilation errors, just lists them all. Since the numbers are high, and they can fluctuate, I think it would be beneficial to print the number of them, although that's probably not in scope here. (javac does print error and apt problem count, but kotlinc doesn't)
There was a problem hiding this comment.
Out of scope as you said. We are removing this because no one cares. If someone wants it I'll be happy to review the pr but otherwise it seems a YAGNI.
TWiStErRob
approved these changes
Oct 19, 2022
schalkms
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "no regression" part of #5436