Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin dokka to v1.6.0 #4328

Merged
merged 1 commit into from Nov 30, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 23, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jetbrains.dokka 1.5.31 -> 1.6.0 age adoption passing confidence

Release Notes

Kotlin/dokka

v1.6.0

Changes:

  • New UI
  • Support of version plugin for single module projects
  • Allow package-level suppression (#​2209), thanks @​owengray-google
  • GFM: Use Markdown syntax to render lists (#​2098), thanks @​sgilson
  • Fix names of nested inheritors
  • Fix adding new custom stylesheets in submodules
  • Add keywords expect and actual in signatures

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #4328 (6e9e766) into main (6a42309) will decrease coverage by 84.24%.
The diff coverage is n/a.

❗ Current head 6e9e766 differs from pull request most recent head 1404789. Consider uploading reports for the commit 1404789 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main   #4328       +/-   ##
============================================
- Coverage     84.24%       0   -84.25%     
============================================
  Files           474       0      -474     
  Lines         10325       0    -10325     
  Branches       1826       0     -1826     
============================================
- Hits           8698       0     -8698     
+ Misses          666       0      -666     
+ Partials        961       0      -961     
Impacted Files Coverage Δ
...o/github/detekt/tooling/api/spec/ProcessingSpec.kt
...lin/io/github/detekt/report/txt/TxtOutputReport.kt
...turbosch/detekt/rules/bugs/NullableToStringCall.kt
...gitlab/arturbosch/detekt/cli/runners/AstPrinter.kt
...kt/rules/exceptions/InstanceOfCheckForException.kt
...ch/detekt/formatting/wrappers/NoWildcardImports.kt
...sch/detekt/core/baseline/BaselineFilteredResult.kt
...arturbosch/detekt/rules/style/UnnecessaryFilter.kt
...rbosch/detekt/rules/style/EqualsOnSignatureLine.kt
...in/io/gitlab/arturbosch/detekt/api/OutputReport.kt
... and 464 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a42309...1404789. Read the comment docs.

@renovate renovate bot force-pushed the renovate/org.jetbrains.dokka-1.x branch 5 times, most recently from bcc7f54 to 2cb8dc2 Compare November 26, 2021 15:14
@chao2zhang chao2zhang added this to the 1.20.0 milestone Nov 26, 2021
@renovate renovate bot force-pushed the renovate/org.jetbrains.dokka-1.x branch from 2cb8dc2 to 661ede9 Compare November 26, 2021 20:11
@3flex
Copy link
Member

3flex commented Nov 29, 2021

Is this blocked because it's actually blocked for some reason, or is it just because it's being held until 1.20.0?

It does bring in Kotlin 1.6 as a dependency but only in the dokkaJekyll and dokkaJekyllRuntime configurations. It doesn't affect detekt's compile or runtime classpath, so dokka can be safely updated independently of Kotlin.

You can see here dokka's configurations use Kotlin 1.6 as dependency while the other configurations use 1.5.31: https://scans.gradle.com/s/drinzrwxhln7w/dependencies?expandAll&projectFilter=WyI6ZGV0ZWt0LWFwaSJd

@chao2zhang
Copy link
Member

Thanks for inspecting the buildscan, it does look like dokka adds only two Gradle configurations without affecting the existing compile classpath.

I marked this PR as blocked just for safety. Given @cortinico is releasing 1.19 on Monday, we could just hold this for probably a few more hours.

@renovate renovate bot force-pushed the renovate/org.jetbrains.dokka-1.x branch 3 times, most recently from 8a0736c to 045af9f Compare November 29, 2021 18:56
@renovate renovate bot force-pushed the renovate/org.jetbrains.dokka-1.x branch from 045af9f to 6e9e766 Compare November 29, 2021 21:50
@renovate renovate bot force-pushed the renovate/org.jetbrains.dokka-1.x branch from 6e9e766 to 1404789 Compare November 29, 2021 23:25
@chao2zhang chao2zhang merged commit 19b8c88 into main Nov 30, 2021
@chao2zhang chao2zhang deleted the renovate/org.jetbrains.dokka-1.x branch November 30, 2021 03:42
@3flex 3flex removed the blocked label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants