Disable CI for Windows & JDK8 #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4403 +/- ##
=========================================
Coverage 84.35% 84.35%
Complexity 3277 3277
=========================================
Files 473 473
Lines 10357 10357
Branches 1827 1827
=========================================
Hits 8737 8737
Misses 668 668
Partials 952 952 Continue to review full report at Codecov.
|
3flex
approved these changes
Dec 27, 2021
chao2zhang
approved these changes
Dec 27, 2021
Does anyone had any idea/lead on what was going on with Win/JDK8? Just to have them as future reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows & JDK8 are really flaky. So flaky that we merge more than 50% of our PRs with CI failing. If I see that a PR passes all checks except Windows/JDK8 I just merge it, it's pointless to check it over and over again to always see "oh, the flakyness again".
This also make our contributors a bit unconfortable. They want their builds green. As when they don't get it, they ask and we say "don'y worry about that". And that is not a good standard. A sample: #4379 (comment)
And the last reason, this also hides other issues. For example, I was using a forbidden function on #4315 but I didn't realised because I saw the red
Xin the PR but I thought "the flakyness".For all of that I think that we should disable this check. If someone wants to expend the time to fix that flakyness it would be great to add that check back again but, meanwhile, I think that it's safer to disable it.