Extend CanBeNonNullable rule to check function params

detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Context.kt

@@ -21,6 +21,7 @@ interface Context {
      * An alias set can be given to additionally check if an alias was used when suppressing.
      * Additionally suppression by rule set id is supported.
      */
+    @Suppress("CanBeNonNullable")
     fun report(finding: Finding, aliases: Set<String> = emptySet(), ruleSetId: RuleSetId? = null) {
         // no-op
     }

detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/SplitPattern.kt

@@ -27,12 +27,16 @@ open class SplitPattern(
     /**
      * Does any part contain given [value]?
      */
-    fun contains(value: String?): Boolean = excludes.any { value?.contains(it, ignoreCase = true) == true }
+    fun contains(value: String?): Boolean {
+        return if (value != null) excludes.any { value.contains(it, ignoreCase = true) } else false
+    }
 
     /**
      * Is there any element which matches the given [value]?
      */
-    fun any(value: String?): Boolean = excludes.any { value?.equals(it, ignoreCase = true) == true }
+    fun any(value: String?): Boolean {
+        return if (value != null) excludes.any { value.equals(it, ignoreCase = true) } else false
+    }
 
     /**
      * Tests if none of the parts contain the given [value].
@@ -47,7 +51,9 @@ open class SplitPattern(
     /**
      * Tests if any part starts with the given [value]
      */
-    fun startWith(value: String?): Boolean = excludes.any { value?.startsWith(it) ?: false }
+    fun startWith(value: String?): Boolean {
+        return if (value != null) excludes.any(value::startsWith) else false
+    }
 
     /**
      * Transforms all parts by given [transform] function.

detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/invoke/DetektInvoker.kt

@@ -66,8 +66,7 @@ internal class DefaultCliInvoker(
         }
     }
 
-    private fun isBuildFailure(msg: String?) =
-        msg != null && "Build failed with" in msg && "issues" in msg
+    private fun isBuildFailure(msg: String) = "Build failed with" in msg && "issues" in msg
 }
 
 private class DryRunInvoker(private val logger: Logger) : DetektInvoker {

detekt-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UselessPostfixExpression.kt

@@ -78,24 +78,26 @@ class UselessPostfixExpression(config: Config = Config.empty) : Rule(config) {
             report(postfixExpression)
         }
 
-        getPostfixExpressionChildren(expression.returnedExpression)
-            ?.forEach { report(it) }
+        expression.returnedExpression
+            ?.let(this::getPostfixExpressionChildren)
+            ?.forEach(this::report)
     }
 
     override fun visitBinaryExpression(expression: KtBinaryExpression) {
         val postfixExpression = expression.right?.asPostFixExpression()
         val leftIdentifierText = expression.left?.text
-        checkPostfixExpression(postfixExpression, leftIdentifierText)
-        getPostfixExpressionChildren(expression.right)
+        postfixExpression?.let { checkPostfixExpression(it, leftIdentifierText) }
+        expression.right
+            ?.let(this::getPostfixExpressionChildren)
             ?.forEach { checkPostfixExpression(it, leftIdentifierText) }
     }
 
     private fun KtExpression.asPostFixExpression() = if (this is KtPostfixExpression &&
         (operationToken === PLUSPLUS || operationToken === MINUSMINUS)
     ) this else null
 
-    private fun checkPostfixExpression(postfixExpression: KtPostfixExpression?, leftIdentifierText: String?) {
-        if (postfixExpression != null && leftIdentifierText == postfixExpression.firstChild?.text) {
+    private fun checkPostfixExpression(postfixExpression: KtPostfixExpression, leftIdentifierText: String?) {
+        if (leftIdentifierText == postfixExpression.firstChild?.text) {
             report(postfixExpression)
         }
     }
@@ -118,7 +120,7 @@ class UselessPostfixExpression(config: Config = Config.empty) : Rule(config) {
         )
     }
 
-    private fun getPostfixExpressionChildren(expression: KtExpression?) =
-        expression?.getChildrenOfType<KtPostfixExpression>()
-            ?.filter { it.operationToken === PLUSPLUS || it.operationToken === MINUSMINUS }
+    private fun getPostfixExpressionChildren(expression: KtExpression) =
+        expression.getChildrenOfType<KtPostfixExpression>()
+            .filter { it.operationToken === PLUSPLUS || it.operationToken === MINUSMINUS }
 }

detekt-rules-exceptions/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/exceptions/ExceptionRaisedInUnexpectedLocation.kt

@@ -65,5 +65,5 @@ class ExceptionRaisedInUnexpectedLocation(config: Config = Config.empty) : Rule(
     private fun isPotentialMethod(function: KtNamedFunction) = methodNames.any { function.name == it }
 
     private fun hasThrowExpression(declaration: KtExpression?) =
-        declaration?.anyDescendantOfType<KtThrowExpression>() == true
+        declaration?.anyDescendantOfType<KtThrowExpression>() ?: false
 }

detekt-rules-exceptions/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/exceptions/TooGenericExceptionCaught.kt

@@ -64,7 +64,7 @@ class TooGenericExceptionCaught(config: Config) : Rule(config) {
     }
 
     private fun isTooGenericException(typeReference: KtTypeReference?): Boolean {
-        return typeReference?.text in exceptionNames
+        return typeReference?.let { it.text in exceptionNames } ?: false
     }
 
     companion object {

detekt-rules-performance/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/performance/ArrayPrimitive.kt

@@ -65,15 +65,14 @@ class ArrayPrimitive(config: Config = Config.empty) : Rule(config) {
     override fun visitNamedDeclaration(declaration: KtNamedDeclaration) {
         super.visitNamedDeclaration(declaration)
         if (declaration is KtCallableDeclaration) {
-            reportArrayPrimitives(declaration.typeReference)
-            reportArrayPrimitives(declaration.receiverTypeReference)
+            declaration.typeReference?.let(this::reportArrayPrimitives)
+            declaration.receiverTypeReference?.let(this::reportArrayPrimitives)
         }
     }
 
-    private fun reportArrayPrimitives(typeReference: KtTypeReference?) {
-        typeReference
-            ?.collectDescendantsOfType<KtTypeReference> { isArrayPrimitive(it) }
-            ?.forEach { report(CodeSmell(issue, Entity.from(it), issue.description)) }
+    private fun reportArrayPrimitives(typeReference: KtTypeReference) {
+        typeReference.collectDescendantsOfType<KtTypeReference> { isArrayPrimitive(it) }
+            .forEach { report(CodeSmell(issue, Entity.from(it), issue.description)) }
     }
 
     private fun isArrayPrimitive(descriptor: CallableDescriptor): Boolean {