Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for #4786 #4801

Merged
merged 4 commits into from May 3, 2022
Merged

Add tests for #4786 #4801

merged 4 commits into from May 3, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 3, 2022

Tests added to show that correctly formatted strings provided on the CLI are parsed as expected, and that the Gradle plugin maps the jvmTarget and languageVersion properties to those CLI flags as expected.

I've also improved the error message provided by the CLI when these flags cannot be parsed which should help narrow down issues.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4801 (f4a2f27) into main (16bbc16) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main    #4801      +/-   ##
============================================
+ Coverage     84.70%   84.72%   +0.01%     
  Complexity     3426     3426              
============================================
  Files           491      491              
  Lines         11253    11257       +4     
  Branches       2069     2069              
============================================
+ Hits           9532     9537       +5     
+ Misses          676      674       -2     
- Partials       1045     1046       +1     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/cli/ArgumentConverters.kt 73.33% <33.33%> (+4.10%) ⬆️
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 90.32% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bbc16...f4a2f27. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we test the improved error messages?

@3flex
Copy link
Member Author

3flex commented May 3, 2022

We don't test the old ones :P

Feel free to do it in a new PR.

@3flex 3flex merged commit ca29f28 into detekt:main May 3, 2022
@3flex 3flex deleted the 4786 branch May 3, 2022 07:58
@cortinico cortinico added this to the 1.21.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants