Remove PsiFile.basePath #7237
Merged
Remove PsiFile.basePath #7237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
added
the
breaking change
This was referenced Apr 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7237 +/- ##
=========================================
Coverage 84.77% 84.78%
- Complexity 3993 3994 +1
=========================================
Files 578 578
Lines 12138 12136 -2
Branches 2484 2483 -1
=========================================
- Hits 10290 10289 -1
+ Misses 624 623 -1
Partials 1224 1224 ☔ View full report in Codecov by Sentry. |
BraisGabin
approved these changes
May 5, 2024
|
Probably we should forbid any usage of It's not doable right now but it would prevent issues in the future. I'll add that as soon as I finish with option to instantiate the same rule more than once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.