Skip to content

fix: Candid UI cannot encode nat8 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2022
Merged

fix: Candid UI cannot encode nat8 #575

merged 4 commits into from
Jun 17, 2022
+51 −20

Conversation

chenyan-dfinity
Copy link
Contributor

Candid UI cannot encode nat8, nat16 types, because the parser only return BigInt for number types.

User get the error: "Cannot convert a BigInt value to a number"

@chenyan-dfinity chenyan-dfinity requested a review from krpeacock May 25, 2022 19:11
@krpeacock krpeacock enabled auto-merge (squash) June 17, 2022 16:45
@krpeacock krpeacock merged commit 7e1568e into main Jun 17, 2022
@krpeacock krpeacock deleted the fix-bigint branch June 17, 2022 16:46
@rvanasa rvanasa mentioned this pull request Jul 25, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krpeacock krpeacock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenyan-dfinity @krpeacock