Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry times #638

Merged
merged 3 commits into from Oct 6, 2022
Merged

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Oct 6, 2022

Description

When making a query call, the response takes a long time if the response is large e.g. 2MB. This is due to the retry method converting the body to text even when this is not needed yet (response is ok).

Fixes #637

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sea-snake sea-snake requested a review from a team as a code owner October 6, 2022 00:16
@sea-snake sea-snake changed the title feat: Fix retry times fix: retry times Oct 6, 2022
Copy link
Contributor

@krpeacock krpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retryTimes breaks query calls with larger responses
2 participants