Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecates @dfinity/authentication #661

Merged
merged 11 commits into from Dec 6, 2022
Merged

chore: deprecates @dfinity/authentication #661

merged 11 commits into from Dec 6, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Dec 6, 2022 •
edited

and moves isDelegationValid check to @dfinity/identity

Description

This package has been virtually unused since genesis, apart from the isDelegationValid check, which can easily be migrated to @dfinity/identity.

Also deprecates the @dfinity/identity-ledgerhq package, which has since migrated to @zondax/ledger-icp

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner December 6, 2022 18:09
@krpeacock krpeacock changed the title choredeprecates @dfinity/authentication chore: deprecates @dfinity/authentication Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022 •
edited

size-limit report 📦

Path Size
@dfinity/agent 89.92 KB (0%)
@dfinity/principal 6.8 KB (0%)
@dfinity/auth-client 311.04 KB (-0.01% 🔽)
@dfinity/assets 92.11 KB (0%)
@dfinity/authentication 0 B (-100% 🔽)
@dfinity/identity 308.81 KB (+0.06% 🔺)

@krpeacock krpeacock merged commit eb69390 into main Dec 6, 2022
@krpeacock krpeacock deleted the kyle/deprecate-authentication branch December 6, 2022 22:28
@smallstepman smallstepman mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @dfx-json