Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes circular deps from barrel files #691

Merged
merged 13 commits into from
Feb 21, 2023
Merged

fix: removes circular deps from barrel files #691

merged 13 commits into from
Feb 21, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 21, 2023 •
edited

Description

To help support build reproducibility issues in Rollup, removes dependencies on index files that can lead to circular dependencies

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 21, 2023 19:04
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023 •
edited

size-limit report 📦

Path Size
@dfinity/agent 88.84 KB (-0.02% 🔽)
@dfinity/candid 15.46 KB (0%)
@dfinity/principal 6.77 KB (0%)
@dfinity/auth-client 95.04 KB (+0.01% 🔺)
@dfinity/assets 91.53 KB (-0.02% 🔽)
@dfinity/identity 91.95 KB (+0.01% 🔺)
@dfinity/identity-secp256k1 230.15 KB (-0.01% 🔽)

@krpeacock krpeacock enabled auto-merge (squash) February 21, 2023 19:48
@krpeacock
feat: changes default host and supports icp-api.io (#690)
6b64030 
* feat: changes default host and rewrites ic0.app calls to icp-api.io

* support for icp0.io domain rerouting
@krpeacock krpeacock merged commit 7be3e07 into main Feb 21, 2023
@krpeacock krpeacock deleted the kyle/circular-deps branch February 21, 2023 21:15
@dskloetd dskloetd mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @ericswanson-dfinity