style: redo scoped styles #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
added a commit
that referenced
this pull request
Jan 19, 2023
# Motivation We have once again build reproducibility issue and despite the fact that we have fully remove the `vite-manifest.json` I suspect the style reproducibility we had to be the root cause. Therefore undo the redo of the global style - i.e. undo PR #1671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #1666 we have moved scoped styles to global style to workaround the build reproducibility of SvelteKit+ViteJS #8291.
This PR redo the changes has #1670 will solve the reproducibility issue by removing the unused vite manifest file from our build results.
PRs
Changes