fix: Remove multiplication of this.#timeout by 1000

[aliclark]

Description

Remove a multiplication of this.#timeout by 1000

Motivation and Context

The value returned by context.getRemainingTimeMillis() was 1000 times greater than expected, ie. 900000000 not 900000.

It has already been multiplied by 1000 at

serverless-offline/src/lambda/LambdaFunction.js

Line 67 in 91592d3

DEFAULT_LAMBDA_TIMEOUT) * 1000

so after multiplying it again at

serverless-offline/src/lambda/handler-runner/in-process-runner/InProcessRunner.js

Line 125 in 1454da7

const executionTimeout = performance.now() + this.#timeout * 1000

it was 1000 times greater than expected.

How Has This Been Tested?

The getRemainingTimeMillis (timeout) check in the LambdaFunction test was incorrectly checking that the function returns a value greater than the original timeout instead of less than the original timeout.

After fixing the checks, the test fails as expected:

  ● LambdaFunction › should use default lambda timeout when timeout is not provided

    expect(received).toBeLessThan(expected)

    Expected: < 900000
    Received:   899999999.83861

      156 |     const remainingTime = await lambdaFunction.runHandler()
      157 | 
    > 158 |     expect(remainingTime).toBeLessThan(DEFAULT_LAMBDA_TIMEOUT * 1000)
          |                           ^
      159 | 
      160 |     // result might be flaky/unreliable:
      161 |     // (assmuning handler runs no longer than 1 s)

      at Object.<anonymous> (src/lambda/__tests__/LambdaFunction.test.js:158:27)

Removing the 1000 multiplication the test is passing again.

[pgrzesik]

Great catch, thank you @aliclark 🙇