Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove multiplication of this.#timeout by 1000 #1177

Merged
merged 3 commits into from
Jun 1, 2021
Merged

fix: Remove multiplication of this.#timeout by 1000 #1177

merged 3 commits into from
Jun 1, 2021

Commits on Feb 15, 2021

  1. Fix incorrect timeout comparison

    @aliclark
    aliclark committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    f9d934f View commit details
    Browse the repository at this point in the history

  2. Put the tested value within the expect() clause

    @aliclark
    aliclark committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    31c87fc View commit details
    Browse the repository at this point in the history

  3. Remove multiplication of this.#timeout by 1000 

    This has already been multiplied by 1000 at
https://github.com/dherault/serverless-offline/blob/91592d3b5bc51fb0975862dcbd06f66be80a7f51/src/lambda/LambdaFunction.js#L67
    @aliclark
    aliclark committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    14a571d View commit details
    Browse the repository at this point in the history