Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puppeteer for M1 support #13250

Closed
wants to merge 3 commits into from
Closed

Update puppeteer for M1 support #13250

wants to merge 3 commits into from

Commits on Mar 10, 2022

  1. Update puppeteer for M1 support 

    See puppeteer/puppeteer#6622 (comment)

changelog_begin
- [Daml Assistant] The create-daml-app template now depends on a more
  recent version of puppeteer to ensure MacOS M1 support. See
  puppeteer/puppeteer#6622 (comment)
  This also requires a later version of react-scripts for compatibility
  with later Chrome versions, See
  webpack/webpack-dev-server#1491
changelog_end
    @aherrmann
    aherrmann committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    15099da View commit details
    Browse the repository at this point in the history

  2. Webpack 5 no longer includes shims 

    See facebook/create-react-app#11756.

This uses react-app-rewired to workaround the issue and remap crypto to
crypto-browserify. See
facebook/create-react-app#11756 (comment).
    @aherrmann
    aherrmann committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    9042335 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. fix some webpack config issues

    @garyverhaegen-da
    garyverhaegen-da committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    4378610 View commit details
    Browse the repository at this point in the history