Update puppeteer for M1 support

[aherrmann-da]

The puppeteer version that we pinned in the create-daml-app template was incompatible with M1. It wants to download a Chromium installation but assumes that none is available on M1 and fails. Later versions (^10.0.0) download an x86_64 release and rely on Rosetta. See puppeteer/puppeteer#6622 (comment)

Pull Request Checklist

• Read and understand the contribution guidelines
• Include appropriate tests
• Set a descriptive title and thorough description
• Add a reference to the issue this PR will solve, if appropriate
• Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
• Normal production system change, include purpose of change in description
• If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

[cocreature]

Thanks!

[aherrmann-da]

This turns into a bit of a rabbit whole. It seems that M1 requires a puppeteer update, which requires a react-script update, which implies a webpack update, which no longer includes shims for js builtins, which breaks create-(daml|react)-app, see facebook/create-react-app#11756. I tried the proposed react-app-rewired fix, but the error remains

Module not found: Error: Can't resolve 'crypto' in '/private/var/folders/s6/2zfqcp895qd0bg00lzmdk7j80000gn/T/extra-dir-80150191221/not-create-daml-app/ui/node_modules/jwt-simple/lib'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
                                                                                                                                        
If you want to include a polyfill, you need to:                                                                                         
        - add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
        - install 'crypto-browserify'                               
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "crypto": false }                       

I'm not terribly familiar with these aspects of create-daml-app, so I might be holding it wrong.
Maybe someone more familiar with this could take a look at it? Perhaps @garyverhaegen-da or @robin-da?

To reproduce, run

$ bazel test //daml-assistant/integration-tests:create-daml-app-tests-proj-name

[garyverhaegen-da]

I haven't really worked on create-daml-app recently but I'll try to take a look next week.

[aherrmann-da]

@garyverhaegen-da Did you have a chance to look into this?

[garyverhaegen-da]

@garyverhaegen-da Did you have a chance to look into this?

Not yet, sorry.

[aherrmann-da]

@garyverhaegen-da Did you have a chance to look into this?

Not yet, sorry.

No worries, I understand there's lots to do.
I spoke with @adriaanm-da this morning and we agreed that it's best to just skip this test on M1 for now to unblock the M1 work.

[garyverhaegen-da]

So the problem right now seems to be that config-overrides is not being loaded at all. I'm trying to figure out how to tell webpack to load it but I'm not familiar with this tooling at all.

[garyverhaegen-da]

I've made some progress: I've managed to get rid of the WebPack issues but now I get:

Creating an optimized production build...
Failed to compile.                
                                       
TypeError: Cannot read property 'get' of undefined

which isn't ideal. Given your chat with @adriaanm-da I'll leave it at that for now.

[aherrmann]

Thank you for digging into this!

which isn't ideal. Given your chat with @adriaanm-da I'll leave it at that for now.

Sounds reasonable 👍

[garyverhaegen-da]

Well, I'm not sure what happened here, but we're now running CI on m1 and these tests don't seem to fail. I've also just updated the create-daml-app tests to succeed on my m1 machine (#15031). So I'm going to assume this has somehow been solved upstream in the meantime and close this one.