Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow builders to accept emoji strings #7616

Merged
merged 5 commits into from Mar 24, 2022
Merged

refactor: allow builders to accept emoji strings #7616

merged 5 commits into from Mar 24, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@suneettipirneni suneettipirneni force-pushed the discord.js/refactor/allow-emoji-strings branch from a06e07f to 4f7cab1 Compare March 7, 2022 15:37
@iCrawl iCrawl added this to the discord.js v14 milestone Mar 7, 2022
@suneettipirneni suneettipirneni force-pushed the discord.js/refactor/allow-emoji-strings branch 2 times, most recently from 28b4c92 to bad49c5 Compare March 7, 2022 22:13
@suneettipirneni suneettipirneni force-pushed the discord.js/refactor/allow-emoji-strings branch from 0fdbd98 to 2718ffa Compare March 11, 2022 21:51
@suneettipirneni suneettipirneni force-pushed the discord.js/refactor/allow-emoji-strings branch 4 times, most recently from 1818da5 to f416fe9 Compare March 14, 2022 15:20
@suneettipirneni suneettipirneni force-pushed the discord.js/refactor/allow-emoji-strings branch from f416fe9 to fd8cc10 Compare March 14, 2022 15:21
vladfrangu
vladfrangu approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add this

packages/discord.js/typings/index.test-d.ts Outdated Show resolved Hide resolved
@suneettipirneni @vladfrangu
Update packages/discord.js/typings/index.test-d.ts
f1698be 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@suneettipirneni suneettipirneni changed the title refactor: allow button builders to accept emoji strings refactor: allow builders to accept emoji strings Mar 16, 2022
@iCrawl iCrawl merged commit fb9a9c2 into discordjs:main Mar 24, 2022
@ImRodry ImRodry mentioned this pull request Mar 27, 2022
Merged
@suneettipirneni suneettipirneni deleted the discord.js/refactor/allow-emoji-strings branch July 6, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry left review comments

@imranbarbhuiya imranbarbhuiya imranbarbhuiya left review comments

@muchnameless muchnameless muchnameless requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:builders packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@suneettipirneni @muchnameless @vladfrangu @iCrawl @kyranet @SpaceEEC @ImRodry @imranbarbhuiya