Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildMemberManager): add() method throws an error #8539

Merged
merged 2 commits into from Aug 21, 2022

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Aug 21, 2022

Please describe the changes this PR makes and why it should be merged:
@discordjs/rest now returns an instance of Uint8Array

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 21, 2022 at 7:03PM (UTC)

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #8539 (a0cfd2f) into main (8028813) will increase coverage by 7.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8539      +/-   ##
==========================================
+ Coverage   78.73%   86.45%   +7.72%     
==========================================
  Files          22       87      +65     
  Lines        3503     8462    +4959     
  Branches      320     1105     +785     
==========================================
+ Hits         2758     7316    +4558     
- Misses        741     1103     +362     
- Partials        4       43      +39     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 73.28% <ø> (?)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (?)
voice 64.08% <ø> (?)
ws 59.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/interactions/slashCommands/options/integer.ts 100.00% <0.00%> (ø)
packages/builders/src/components/Component.ts 100.00% <0.00%> (ø)
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <0.00%> (ø)
...ges/builders/src/components/textInput/TextInput.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
packages/voice/src/networking/Networking.ts 3.18% <0.00%> (ø)
packages/builders/src/util/normalizeArray.ts 100.00% <0.00%> (ø)
...ApplicationCommandNumericOptionMinMaxValueMixin.ts 100.00% <0.00%> (ø)
...s/src/interactions/slashCommands/options/string.ts 100.00% <0.00%> (ø)
...ashCommands/mixins/ApplicationCommandOptionBase.ts 100.00% <0.00%> (ø)
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite added this to the discord.js v14.3 milestone Aug 21, 2022
@kodiakhq kodiakhq bot merged commit 3bef901 into discordjs:main Aug 21, 2022
@Syjalo Syjalo deleted the fix/GuildMemberManager#add() branch August 21, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants