Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Typings): add missing typings for HttpError -> requestData #5742

Merged
merged 9 commits into from Jun 3, 2021
Merged

fix(Typings): add missing typings for HttpError -> requestData #5742

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5820b35
fix(Typings): add missing typings for `HttpError` -> `requestData`
casperiv0 Jun 3, 2021
9ffaba9
fix(Typings): alphabetical order
casperiv0 Jun 3, 2021
d50a495
fix(Typings): semicolons
casperiv0 Jun 3, 2021
07658bc
fix(Typings): use `unknown` instead of `any`
casperiv0 Jun 3, 2021
362087f
fix(Typings): update constructors
casperiv0 Jun 3, 2021
4b7d802
Apply suggestions from code review
casperiv0 Jun 3, 2021
6683640
fix(Typings): update JSDoc from code review suggestion
casperiv0 Jun 3, 2021
3eea16b
fix(Typings): Apply suggestions from code review
casperiv0 Jun 3, 2021
b77fca3
Merge branch 'master' of https://github.com/discordjs/discord.js into…
casperiv0 Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions typings/index.d.ts
View file
Open in desktop
Expand Up @@ -710,6 +710,7 @@ declare module 'discord.js' {
public method: string;
public path: string;
public httpStatus: number;
public requestData: HTTPErrorData;
}

export class DMChannel extends TextBasedChannel(Channel, ['bulkDelete']) {
Expand Down Expand Up @@ -1050,6 +1051,7 @@ declare module 'discord.js' {
public method: string;
public name: string;
public path: string;
public requestData: HTTPErrorData;
}

export class Integration extends Base {
Expand Down Expand Up @@ -3083,6 +3085,16 @@ declare module 'discord.js' {
cache?: boolean;
}

interface HTTPAttachmentData {
name: string;
casperiv0 marked this conversation as resolved.
Show resolved Hide resolved
file: Buffer;
casperiv0 marked this conversation as resolved.
Show resolved Hide resolved
}

interface HTTPErrorData {
json: any;
casperiv0 marked this conversation as resolved.
Show resolved Hide resolved
files: HTTPAttachmentData[];
}

interface HTTPOptions {
api?: string;
version?: number;
Expand Down