Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove extended collection #6246

Merged
merged 2 commits into from Jul 31, 2021
Merged

refactor: remove extended collection #6246

merged 2 commits into from Jul 31, 2021

Conversation

1Computer1
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Depends on discordjs/collection#44. Removes usage of Util.flatten on entries that do not have toJSON.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

kyranet
kyranet previously requested changes Jul 31, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance, just one thing, LGTM otherwise

typings/index.d.ts Outdated Show resolved Hide resolved
@kyranet kyranet added this to the Version 13 milestone Jul 31, 2021
@kyranet kyranet mentioned this pull request Jul 31, 2021
Closed
@kyranet kyranet linked an issue Jul 31, 2021 that may be closed by this pull request
error from Collection util #6236
Closed
@iCrawl iCrawl requested a review from kyranet July 31, 2021 09:07
@iCrawl iCrawl merged commit 00bae4f into discordjs:master Jul 31, 2021
@ghost

This comment has been minimized.

Sign in to view
@Techbot121
Copy link

Techbot121 commented Jul 31, 2021 •
edited

https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L41 I assume this slipped by?
Edited: this has been fixed with #6256

IRONM00N pushed a commit to TanzaniteBot/discord.js that referenced this pull request Aug 1, 2021
@1Computer1 @iCrawl @IRONM00N
refactor: remove extended collection (discordjs#6246)
fc772f2 
Co-authored-by: iCrawl <buechler.noel@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

error from Collection util
6 participants
@1Computer1 @Techbot121 @vladfrangu @iCrawl @kyranet @SpaceEEC