-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Client): add global sweepers #6825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance..this looks awesome!
69f8cff
to
3fc2b5b
Compare
4a7650e
to
4152aa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things, nice work overall ^^
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-Authored-By: Vlad Frangu <kingdgrizzle@gmail.com>
Co-Authored-By: Rodry <38259440+ImRodry@users.noreply.github.com> Co-Authored-By: Almeida <almeidx@pm.me>
Co-Authored-By: Antonio Román <kyradiscord@gmail.com>
bc9271d
to
9a2594a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the last 2 requests, everything else looks fine to me.
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the importance of the count bits, but here they are. 😅
Co-Authored-By: Antonio Román <kyradiscord@gmail.com>
Please describe the changes this PR makes and why it should be merged:
LimitedCollection
to provide max size functionality. After doing the work to get to this point, that seemed out of scope, and can easily be tackled in another PR. This does mean that you are still storing extra properties on LimitedCollection for now, however hopefully not tracking a timeout.In order to keep this semver: minor, default options have unfortunately not been switched to use the sweepers in this PR.
Status and versioning classification: