New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Sharding): Update Shard#broadcastEval
to v13 syntax.
#695
refactor(Sharding): Update Shard#broadcastEval
to v13 syntax.
#695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, looks good otherwise 👍🏼
Co-authored by: Danktuary <sanc.pw@gmail.com>
Oh, that's strange. Looks fine at a glance, but maybe it's because If that doesn't work, just add a |
This worked! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't just remove quotes, that's not how you translate it.
Co-authored by: kyranet <kyradiscord@gmail.com>
Co-authored-by: Danktuary <sanc.pw@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs to address code samples for sharding (remove v11/v12 folders)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the .broadcastEval(client => ...)
with .broadcastEval(c => ...)
, because client
is already declared in the upper scope.
Co-authored-by: Sanctuary <Danktuary@users.noreply.github.com>
Please describe the changes this PR makes and why it should be merged:
Demo
This PR updates the
Sharding
section of the guide to be up-to-date with the breaking changeShardingManager#broadcastEval
received in discordjs/discord.js#5756. This change was made to fix an RCE vulnerability explained in this repo.A lot of things might need to be adjusted/fixed/rewritten, and I will happy to do so when suggested.
Status
Sharding
.context
.