Add DiscardOnSave field to Interaction type #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DiscardOnSave field may be set to true by hooks, in order to discard an interaction before saving it on disk. See issue #80 for some background info.
|
@sergiught , please check this one out and let me know how it looks. Thanks! |
Codecov Report
@@ Coverage Diff @@
## v3 #81 +/- ##
=======================================
Coverage 77.69% 77.69%
=======================================
Files 1 1
Lines 278 278
=======================================
Hits 216 216
Misses 48 48
Partials 14 14 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2 tasks
|
Hey @dnaeon 👋🏻 , Thanks a lot for the quick turnaround! I was able to open a draft PR with the changes brought here within -> https://github.com/auth0/terraform-provider-auth0/pull/382/files#diff-54a6153bd2ec74433ca48fda4f010eadce4412bd67975099b4d2095f3396ebcfL825 and I can confirm this works like a charm. |
sergiught
approved these changes
Oct 25, 2022
|
Hey @sergiught , thanks! Merged and tagged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DiscardOnSave field may be set to true by hooks, in order to discard an interaction before saving it on disk.
See issue #80 for some background info.