Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Checkbox): add indeterminate state #3515

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

AadneRo
Copy link
Contributor

@AadneRo AadneRo commented May 2, 2024

Visual changed for checkbox indeterminate state

  • fix undesired change of checked->unchecked animation
  • Add sbanken theme
  • fix shanked error+hover state -> this is wrong compared to the designs

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 1:57pm

@AadneRo AadneRo changed the title Feat/checkbox patial state Feat(Checkbox) add indeterminate state May 2, 2024
Copy link

codesandbox-ci bot commented May 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker changed the title Feat(Checkbox) add indeterminate state feat(Checkbox): add indeterminate state May 2, 2024
@AadneRo AadneRo force-pushed the feat/checkbox-patial-state branch from 324a90d to d87b232 Compare May 3, 2024 07:59
@AadneRo AadneRo force-pushed the feat/checkbox-patial-state branch from d87b232 to 4105386 Compare May 3, 2024 14:28
@AadneRo AadneRo force-pushed the feat/checkbox-patial-state branch 3 times, most recently from 2fc848f to c60e749 Compare May 7, 2024 14:16
- Add checkbox indeterminate state
- fix sbanken checkbox theme
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great work ⭐

@AadneRo AadneRo merged commit d1ba274 into main May 14, 2024
10 checks passed
@AadneRo AadneRo deleted the feat/checkbox-patial-state branch May 14, 2024 07:42
tujoworker pushed a commit that referenced this pull request May 15, 2024
## [10.31.0](v10.30.2...v10.31.0) (2024-05-15)

### 📝 Documentation

* **Checkbox:** update props to camelCase ([#3555](#3555)) ([22accc9](22accc9))

### 🐛 Bug Fixes

* **Drawer:** prevent `auto-focus` from triggering in inital mount when `openState` is `false` ([#3534](#3534)) ([07c741f](07c741f))
* **forms:** keep field props in memory during Wizard step change ([#3553](#3553)) ([02329dd](02329dd))
* **HeightAnimation:** set width during height calculation ([#3557](#3557)) ([8e59eaf](8e59eaf))

### ✨ Features

* **Checkbox:** add indeterminate state ([#3515](#3515)) ([d1ba274](d1ba274))
* **forms:** add `required` prop to Wizard.Step ([#3556](#3556)) ([fbb47e4](fbb47e4))
* **forms:** add Field.Indeterminate ([#3513](#3513)) ([7e84a11](7e84a11))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants