Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/5.0 #802

Closed
wants to merge 12 commits into from
Closed

Feat/5.0 #802

wants to merge 12 commits into from

Conversation

QingWei-Li
Copy link
Member

@QingWei-Li QingWei-Li commented Mar 31, 2019

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

The other two features I don't plan to develop. Not much effect.

@docsifyjs/core @jhildenbiddle

First of all, I have to apologize.

I haven't read the issues for a long time and haven't noticed your email. I may have to leave this project.

I have promoted @timaschew to owner and hope that you can continue to maintain docsify.

This is my last contribution to docsify. If you feel that there is no problem, then I will release 5.0. And give the release permission to your.

@QingWei-Li
Copy link
Member Author

@timaschew
If you need permission to post, please let me know your npm account.

@timaschew
Copy link
Member

timaschew commented Mar 31, 2019

As @jhildenbiddle mentioned here: #657 (comment)
I agree with him to delay this PR (bump to 5.0) until some bugs are fixed which should be released as 4.x
Merging this without bumping the major version seems not an option since this PR contains some breaking changes like the syntax for the helpers.

@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open and removed wontfix labels Feb 4, 2020
@anikethsaha anikethsaha mentioned this pull request Mar 10, 2020
@trusktr
Copy link
Member

trusktr commented Jun 8, 2020

Develop has diverged from this PR. There's 11 files with conflicts. What do we want to do?

I think we either

  • take effort to clean up the PR
  • or close it, and open a new branch

Either way, we should not let existing branches get stale. After each pull request is merged, we should merge develop into the breaking-release branch (that is, if we want to keep the breaking changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned This is to pinned the PR/Issue in order to keep it open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants