Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack v4 #47

Merged
merged 6 commits into from Dec 16, 2018
Merged

Upgrade webpack v4 #47

merged 6 commits into from Dec 16, 2018

Conversation

mwistrand
Copy link
Contributor

  • Update webpack-contrib to next
  • Replace ExtractTextPlugin with MiniCssExtractPlugin, but pin to 0.4.2 until Incompatibility with the latest version of mini-css-extract-plugin (0.4.3) shellscape/webpack-manifest-plugin#167 is resolved.
  • Replace removed CommonsChunkPlugin with optimize.splitChunks configuration option
  • Remove plugins provided by mode configuration option: NamedChunksPlugin, NamedModulesPlugin, and DefinePlugin
  • Use terser-webpack-plugin over uglifyjs-webpack-plugin-terser
  • Upgrade to webpack-mild-compile@3.3.1
  • Force CSS splitting by entry
  • Filter css order warnings
  • Add optimize-css-assets-webpack-plugin to dist config
  • Update tapable typings

Resolves #26

- Update webpack-contrib to next
- Replace ExtractTextPlugin with MiniCssExtractPlugin, but pin to 0.4.2
  until shellscape/webpack-manifest-plugin#167 is resolved.
- Replace removed CommonsChunkPlugin with `optimize.splitChunks`
  configuration option
- Remove plugins provided by `mode` configuration option:
  NamedChunksPlugin, NamedModulesPlugin, and DefinePlugin
- Use terser-webpack-plugin over uglifyjs-webpack-plugin-terser
- Upgrade to webpack-mild-compile@3.3.1
- Force CSS splitting by entry
- Filter css order warnings
- Add optimize-css-assets-webpack-plugin to dist config
- Update tapable typings
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #47 into master will decrease coverage by 1.79%.
The diff coverage is 31.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #47     +/-   ##
=========================================
- Coverage   71.62%   69.83%   -1.8%     
=========================================
  Files           8        8             
  Lines         356      358      +2     
  Branches       61       62      +1     
=========================================
- Hits          255      250      -5     
- Misses        101      108      +7
Impacted Files Coverage Δ
src/test.config.ts 14.63% <0%> (-1.65%) ⬇️
src/dev.config.ts 30.76% <0%> (-2.57%) ⬇️
src/base.config.ts 30.43% <37.5%> (-2.38%) ⬇️
src/dist.config.ts 44.44% <50%> (-7.73%) ⬇️
src/main.ts 95.23% <62.5%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f79356...ac42a7d. Read the comment docs.

@mwistrand mwistrand merged commit d81d320 into dojo:master Dec 16, 2018
@mwistrand mwistrand deleted the upgrade-webpack-v4 branch August 7, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Webpack 4
2 participants