Add support for creating ECR repos #24
Conversation
|
Hey @shubham149, just looking for feedback on this PR when you get a chance. Let me know if you need more information/context. |
cmd/kaniko-ecr/main.go
Outdated
| var createErr error | ||
| switch registry { | ||
| case ecrPublicDomain: | ||
| splitRepo := strings.SplitN(repo, "/", 2) |
There was a problem hiding this comment.
Currently it is assumed that user provided repo does not have registry present in it. We can possibly use this in L156 as well as L180.
if !strings.HasPrefix(repo, registry) { repo = fmt.Sprintf("%s/%s", registry, repo) }
There was a problem hiding this comment.
Hey @shubham149, thanks for taking a look at this. This was actually splitting on the registry alias, not the public domain itself. See aws docs here. For example, all ECR public registries look like public.ecr.aws/<registry-alias>/<repositiry-name>:<tag>.
However, I've updated the logic to instead include the registry alias in the registry field, instead of the repo field, which I think is a little less confusing.
So now you can just define:
...
registry: public.ecr.aws/registry-alias
repo: repo-name
create_repository: true
...
This adds support for creating the ECR repo, similar to https://github.com/drone-plugins/drone-docker and https://github.com/drone-plugins/drone-buildah.