Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential NPE in InstrumentedResourceMethodApplicationListener #3179

Merged
merged 1 commit into from Feb 15, 2023
Merged

Fix potential NPE in InstrumentedResourceMethodApplicationListener #3179

merged 1 commit into from Feb 15, 2023

Conversation

joschi
Copy link
Member

@joschi joschi commented Feb 15, 2023

No description provided.

@joschi joschi added the bug label Feb 15, 2023
@joschi joschi self-assigned this Feb 15, 2023
@joschi joschi requested review from a team as code owners February 15, 2023 23:06
@joschi joschi enabled auto-merge (squash) February 15, 2023 23:06
@joschi joschi added this to the 4.2.17 milestone Feb 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
100.0% 100.0% Duplication

@joschi joschi merged commit cf4a005 into release/4.2.x Feb 15, 2023
@joschi joschi deleted the InstrumentedResourceMethodApplicationListener-npe-4.2.x branch February 15, 2023 23:11
@dennyac
Copy link
Contributor

dennyac commented Feb 16, 2023

Good catch. Thanks! Curious how you detected this.

@joschi
Copy link
Member Author

joschi commented Feb 16, 2023

Good catch. Thanks! Curious how you detected this.

@dennyac SonarScan/SonarCloud is to blame. 😉

@dennyac dennyac mentioned this pull request Feb 22, 2023
Merged
@LuciferYang LuciferYang mentioned this pull request Mar 3, 2023
Closed
srowen pushed a commit to apache/spark that referenced this pull request Mar 6, 2023
@LuciferYang @srowen
[SPARK-42654][BUILD] Upgrade dropwizard metrics 4.2.17
4b8b368 
### What changes were proposed in this pull request?
This pr aims upgrade dropwizard metrics to 4.2.15.

### Why are the changes needed?
The new version bring some bug fix:

- dropwizard/metrics#3125
- dropwizard/metrics#3179

And the release notes as follows:

- https://github.com/dropwizard/metrics/releases/tag/v4.2.16
- https://github.com/dropwizard/metrics/releases/tag/v4.2.17

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass Github Actions

Closes #40254 from LuciferYang/SPARK-42654.

Lead-authored-by: yangjie01 <yangjie01@baidu.com>
Co-authored-by: YangJie <yangjie01@baidu.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joschi joschi

Labels
bug
Projects
None yet
Milestone
4.2.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joschi @dennyac