New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make config.storage.sync injection optional and log any issues #5204
Make config.storage.sync injection optional and log any issues #5204
Conversation
@bircher @greg any thoughts? See linked issue. @greg-1-anderson |
I am ok with this approach. But I think we need to throw the exception also when trying to use the uninitialized service. Because otherwise it will be difficult to understand why the command doesn't work. |
I don't have time to try it myself right now. The things that are unclear to me from the linked issue:
Having an indicator in |
9d50715
to
4ff5d46
Compare
@bircher do you mean adding a check in |
Ok so I checked more closely again. And we should refactor this a lot. I don't know what part of this is considered "public api of drush" But I don't think it is a good idea to extend the import and export command classes. |
so tldr: looks good to me |
Fixes #5195.