Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use own DrupalFinder which pulls path from Composer API #5542

Merged
merged 8 commits into from
May 4, 2023

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Apr 22, 2023

  • Implements our own DrupalFinder
  • Keeps using webflo/drupal-finder when we want to discover roots that are different from the bootstrapped site. That happens in ArchiveDump and in Preflight (when you use a site alias with a local drupal root)

@weitzman
Copy link
Member Author

One benefit is that we no longer dont rely on any extra in the project's composer.json

@claudiu-cristea
Copy link
Member

What happens for the projects not using composer? Or Drush doesn’t support such sites?

@weitzman
Copy link
Member Author

Not supported, for several years now - "Drush only supports one install method. It requires that your Drupal site be built with Composer and Drush be listed as a dependency." https://www.drush.org/latest/install/

@greg-1-anderson
Copy link
Member

Drush 12 removes support for non-Composer-managed sites. I think that the "one install method" referenced above was added in Drush 9, although non-Composer-managed sites still "happened to work", mostly in support of ISP configurations.

Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it; it's nice and clean. Would be a good thing for the upstream to adopt too. I'm fine with using our own implementation until that happens.

@greg-1-anderson
Copy link
Member

I don't have any good theories about why this is breaking on Windows.

@weitzman weitzman merged commit a386738 into 12.x May 4, 2023
2 checks passed
@weitzman weitzman deleted the no-drupal-finder branch May 4, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants