Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.7 RC #2271

Merged
merged 4 commits into from
Jan 10, 2023
Merged

version 0.7 RC #2271

merged 4 commits into from
Jan 10, 2023

Conversation

alexcb
Copy link
Collaborator

@alexcb alexcb commented Oct 12, 2022

New 0.7 version with corresponding default-enabled features, along with
updated tests.

@alexcb alexcb force-pushed the acb/version0.7 branch 4 times, most recently from a04ceeb to a7c7c24 Compare October 14, 2022 21:13
@alexcb alexcb force-pushed the acb/version0.7 branch 2 times, most recently from b828153 to f3bdbc6 Compare December 5, 2022 21:33
@alexcb alexcb changed the title Acb/version0.7 version 0.7 RC Dec 5, 2022
@alexcb alexcb force-pushed the acb/version0.7 branch 4 times, most recently from 3e05d18 to ed6b172 Compare December 8, 2022 00:30
@alexcb alexcb force-pushed the acb/version0.7 branch 5 times, most recently from 1a0389b to b92e99c Compare January 5, 2023 19:44
@alexcb alexcb force-pushed the acb/version0.7 branch 8 times, most recently from cd43e2a to 91ee343 Compare January 9, 2023 22:09
New 0.7 version with corresponding default-enabled features, along with
updated tests.

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb marked this pull request as ready for review January 9, 2023 22:57
@alexcb
Copy link
Collaborator Author

alexcb commented Jan 9, 2023

There are a few tests that are left at VERSION 0.6, which I will address in follow-up PRs.

examples/secrets/Earthfile Outdated Show resolved Hide resolved
FROM alpine:3.15
RUN apk add libcap # for capsh

IMPORT --allow-privileged github.com/earthly/test-remote/privileged:main
IMPORT --allow-privileged github.com/earthly/test-remote/privileged:45359a92acdd7ef27d561d0836099cdacc508e40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need to update these tags after merge? (this is more of a process question than a review comment)

### Changed

- `VERSION` command is now required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move ### Changed as the first section. This is the stuff that will contain breaking changes too and it feels pretty important.

@@ -4,6 +4,35 @@ All notable changes to [Earthly](https://github.com/earthly/earthly) will be doc

## Unreleased

## v0.7.0-rc1 - 2022-10-12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to use a January date in here?

Suggested change
## v0.7.0-rc1 - 2022-10-12
## v0.7.0-rc1 - 2023-01-13

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll update this when we rewrite the release notes prior to the actual release -- there'll be a few more PRs before then.

@@ -4,6 +4,35 @@ All notable changes to [Earthly](https://github.com/earthly/earthly) will be doc

## Unreleased

## v0.7.0-rc1 - 2022-10-12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes are not final, correct? Can we still edit them after merging to main? We will have more stuff in here to expand on. I would add most of the feature flags in more detail.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct -- even though I'm merging this in -- I do not intend to release it as is.

@alexcb alexcb merged commit de73e7d into main Jan 10, 2023
@alexcb alexcb deleted the acb/version0.7 branch January 10, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants