0.11.0: preserve only in upload end

[makandre]

Signed-off-by: Andrew Mak makandre@ca.ibm.com

What type of PR is this ?

• Bug fix
• Enhancement

What does this PR do ?

Follow-up to PR #2696, preserve timestamp only in upload/end and not in bind/end

Which issue(s) does this PR fix ?

Link to the Codewind repository issue(s) this PR fixes or references:

#2699

Does this PR require a documentation change ?

Any special notes for your reviewer ?

[elsony]

Can you do some tests to make sure our incremental build (both Appsody and Codewind style of apps) are only detecting update on the changed files only instead of all files?

[codecov]

Codecov Report

Merging #2701 into 0.11.0 will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           0.11.0    #2701      +/-   ##
==========================================
- Coverage   59.85%   59.77%   -0.08%     
==========================================
  Files          98       98              
  Lines       10006    10006              
  Branches     1687     1688       +1     
==========================================
- Hits         5989     5981       -8     
- Misses       4017     4025       +8     

Impacted Files	Coverage Δ
src/pfe/portal/modules/utils/sharedFunctions.js	84.61% <100.00%> (ø)
src/pfe/portal/routes/projects/remoteBind.route.js	80.97% <100.00%> (-2.62%)	⬇️
src/pfe/portal/modules/utils/dockerFunctions.js	31.46% <0.00%> (-3.38%)	⬇️
src/pfe/portal/modules/LoadRunner.js	61.86% <0.00%> (+0.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670a233...ecd7708. Read the comment docs.

[makandre]

@elsony

This PR revert the behaviour for bind/end, so essentially the effective change in both PRs is now in upload/end, we preserve the timestamp.

So I tested with Codewind spring project as an example, and in fact it appears the behaviour now is improved than before. Without preserving timestamp, regardless of what file I changed (even if it's just a file in src/test/java, I saw this in the maven build log for the default-compile phase:

[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ cwspring02 ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 4 source files to /root/app/./target/classes

After the change to preserve timestamp, if I changed a file in src/test/java, I see this now:

[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ cwspring02 ---
[INFO] Nothing to compile - all classes are up to date

So I think we were actually compiling more than necessary before because when the project is copied from cw-temp, all the timestamps are touched and appears updated.

Edit: can confirm this is true for Codewind microprofile project as well

[hhellyer]

@elsony - I did a quick check locally instrumenting the upload REST function. Only the changed files are be being uploaded. I'm going to approve and merge this fix so it's ready for 0.11.0.

[hhellyer]

LGTM - I think #2705 might be a better fix long term but with a bit more risk of destabilising this release as it upgrades fs-extra. I'll merge this into 0.11.0 but the fix in master will probably be upgrading fs-extra.