Open XL segfault fix and workaround for si.cpp macro collision #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Apr 25, 2024
The omrthread_get_ras_tid() function in rasthrsup.c was causing a segmentation fault with Open XL as pthread_t is structured in a different manner. This fixes that while keeping support with XLC. The header grp.h used in si.cpp also has a macro collision with the native locale header from Open XL. The reordering of headers is a workaround for the core problem. A issue has also been created in order to use a better macro name __grp.
babsingh
reviewed
Apr 30, 2024
|
jenkins build all |
babsingh
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
LGTM. The z/OS build has passed. @keithc-ca Do the changes look good to you?
keithc-ca
approved these changes
May 1, 2024
|
Only unrelated failures are seen:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The omrthread_get_ras_tid() function in rasthrsup.c was causing a segmentation fault with Open XL as pthread_t is structured in a different manner. This fixes that while keeping support with XLC. The header grp.h used in si.cpp also has a macro collision with the native locale header from Open XL. The reordering of headers is a workaround for the core problem. A issue has also been created in order to use a better macro name __grp.
(This is one part of the multiple changes added for supporting Open XL compilation on OMR)