Resolve potential race in resume/reconnect #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If resume continued to run through a disconnect/reconnect
cycle then a race would be caused by c.stop = make(chan struct{})
Likely to be a rare issue in production (a lot of messages persisted,
slow store, and/or fast reconnect).
Also to enable tests to be run with the race detector the
Test_ConnectRetry has been updated to avoid a race.
Signed-off-by: Matt Brittan <matt@brittan.nz>
The initil implementation of this made client.go more confusing than was required (as the change was just to support testing). Added a mutex to support this as that approach might be useful with other tests too. Signed-off-by: Matt Brittan <matt@brittan.nz>
|
My original changes to remove the race in Test_ConnectRetry added complexity to client.go (and was a bit ugly). I have changed this to use a mutex instead as I think its easier to follow. |
|
That's definitely better, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If resume continued to run through a disconnect/reconnect
cycle then a race would be caused by c.stop = make(chan struct{})
Likely to be a rare issue in production (a lot of messages persisted,
slow store, and/or fast reconnect).
Also to enable tests to be run with the race detector
Test_ConnectRetry has been updated to avoid a race.
Probably closes #362 (cannot be sure becasue issue does ont provide sufficient detail)
Signed-off-by: Matt Brittan matt@brittan.nz