Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve potential race in resume/reconnect #365

Merged
merged 2 commits into from Oct 24, 2019
Merged

Resolve potential race in resume/reconnect #365

merged 2 commits into from Oct 24, 2019

Commits on Oct 16, 2019

  1. Resolve potential race in resume/reconnect

    If resume continued to run through a disconnect/reconnect
    cycle then a race would be caused by c.stop = make(chan struct{})
    Likely to be a rare issue in production (a lot of messages persisted,
    slow store, and/or fast reconnect).
    Also to enable tests to be run with the race detector the
    Test_ConnectRetry has been updated to avoid a race.
    
    Signed-off-by: Matt Brittan <matt@brittan.nz>
    MattBrittan committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    0b08052 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Simplify insertion of new broker in test

    The initil implementation of this made client.go more
    confusing than was required (as the change was just
    to support testing). Added a mutex to support this as
    that approach might be useful with other tests too.
    
    Signed-off-by: Matt Brittan <matt@brittan.nz>
    MattBrittan committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    ed4e938 View commit details
    Browse the repository at this point in the history