Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Done() method to Token for use with select #447

Merged
merged 1 commit into from Sep 18, 2020
Merged

Add Done() method to Token for use with select #447

merged 1 commit into from Sep 18, 2020

Conversation

rittneje
Copy link
Contributor

@rittneje rittneje commented Aug 7, 2020

Add a Done method to the Token interface so we can abort waiting upon context cancellation, for example. Fixes #445.

@rittneje
Add Done() method to Token for use with select
8d7529a 
Signed-off-by: Jesse Rittner <rittneje@gmail.com>
@rittneje
Copy link
Contributor Author

@alsm Please take a look.

@alsm
Copy link
Contributor

alsm commented Sep 18, 2020

Thanks for the contribution

@alsm alsm merged commit 4b393de into eclipse:master Sep 18, 2020
@adriansmares adriansmares mentioned this pull request Oct 9, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add method to Token interface for getting pull-only channel
2 participants
@rittneje @alsm