Accept readonly arrays on assignment #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
requested changes
Mar 1, 2024
CarsonF
force-pushed
the
accept-readonly-input-arrays
branch
from
3fda5b6
to
f2a85e0
Compare
This is safe because it's saying we expect less. Rather than giving less on output, which could be a breaking change.
CarsonF
force-pushed
the
accept-readonly-input-arrays
branch
from
9cfe3f8
to
1ea2dfd
Compare
…iteral to use isParam / scalar const type
…ing for less since it is input)
CarsonF
force-pushed
the
accept-readonly-input-arrays
branch
from
ff8f48b
to
4d97aaf
Compare
scotttrinh
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is safe because it's saying we expect less.
Rather than giving less on output, which could be a breaking change.