Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept readonly arrays on assignment #884

Merged
merged 5 commits into from Mar 1, 2024
Merged

Accept readonly arrays on assignment #884

merged 5 commits into from Mar 1, 2024

Commits on Mar 1, 2024

  1. Add test to ensure readonly arrays are accepted in

    @CarsonF
    CarsonF committed Mar 1, 2024
    Copy the full SHA
    985734b View commit details
    Browse the repository at this point in the history

  2. Accept readonly arrays on assignment 

    This is safe because it's saying we expect less.
Rather than giving less on output, which could be a breaking change.
    @CarsonF
    CarsonF committed Mar 1, 2024
    Copy the full SHA
    1ea2dfd View commit details
    Browse the repository at this point in the history

  3. Fix test to reflect schema

    @CarsonF
    CarsonF committed Mar 1, 2024
    Copy the full SHA
    d502e2a View commit details
    Browse the repository at this point in the history

  4. Change ArrayType to be readonly when isParam. Change getAssignmentL… 

    …iteral to use isParam / scalar const type
    @CarsonF
    CarsonF committed Mar 1, 2024
    Copy the full SHA
    16c0625 View commit details
    Browse the repository at this point in the history

  5. Change params test to reflect deep readonly arrays (again this is ask… 

    …ing for less since it is input)
    @CarsonF
    CarsonF committed Mar 1, 2024
    Copy the full SHA
    4d97aaf View commit details
    Browse the repository at this point in the history