Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collision in QB with nested object & module names #900

Merged
merged 3 commits into from Mar 12, 2024
Merged

Fix collision in QB with nested object & module names #900

merged 3 commits into from Mar 12, 2024

Commits on Mar 11, 2024

  1. Add test schema to expose failure

    @CarsonF
    CarsonF committed Mar 11, 2024
    Copy the full SHA
    c568605 View commit details
    Browse the repository at this point in the history

  2. Use full namespace in import 

    Previously these FQNs
A::X::Y
B::X::Y

were emitted as:
import _X from './A/X';
import _X from './B/X';

now they are emitted as:
import _AX from './A/X';
import _BX from './B/X';

I opted to use `indentRef.name` instead of path logic.
It just seemed easier, but I understand this is a deviation.
    @CarsonF
    CarsonF committed Mar 11, 2024
    Copy the full SHA
    6aa7dd9 View commit details
    Browse the repository at this point in the history

  3. Merged nested objects with nested modules (just like top level) 

    Previously these FQNs
A::B
A::B::C

were emitted as:
type __defaultExports = {
  "B": typeof B;
  "B": typeof _module__B;
};

Now these types & values are merged, just as in generateIndex.
    @CarsonF
    CarsonF committed Mar 11, 2024
    Copy the full SHA
    126eeea View commit details
    Browse the repository at this point in the history